Skip to content

Add XML to LBFGS Maximum Entropy Classifier - #3389

Merged
wschin merged 12 commits into
dotnet:masterfrom
wschin:me-xml
Apr 20, 2019
Merged

Add XML to LBFGS Maximum Entropy Classifier#3389
wschin merged 12 commits into
dotnet:masterfrom
wschin:me-xml

Conversation

@wschin

@wschin wschin commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

Toward #2522 following #3218.

@wschin wschin added the documentation Related to documentation of ML.NET label Apr 18, 2019
@wschin wschin self-assigned this Apr 18, 2019
@codecov

codecov Bot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3389 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
+ Coverage   72.69%   72.75%   +0.05%     
==========================================
  Files         807      807              
  Lines      145172   145335     +163     
  Branches    16225    16232       +7     
==========================================
+ Hits       105533   105733     +200     
+ Misses      35223    35183      -40     
- Partials     4416     4419       +3
Flag Coverage Δ
#Debug 72.75% <ø> (+0.05%) ⬆️
#production 68.26% <ø> (+0.03%) ⬆️
#test 89.02% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
...LogisticRegression/MulticlassLogisticRegression.cs 67.61% <ø> (ø) ⬆️
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <ø> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
src/Microsoft.ML.Data/Transforms/KeyToValue.cs 79.16% <0%> (-0.65%) ⬇️
...ML.Transforms/MutualInformationFeatureSelection.cs 78.58% <0%> (-0.33%) ⬇️
...ML.Data/Transforms/ColumnConcatenatingEstimator.cs 80.3% <0%> (ø) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 87.52% <0%> (ø) ⬆️
src/Microsoft.ML.Recommender/RecommenderCatalog.cs 70.83% <0%> (ø) ⬆️
...icrosoft.ML.FastTree/RandomForestClassification.cs 78.07% <0%> (ø) ⬆️
...forms/FeatureContributionCalculationTransformer.cs 73.55% <0%> (ø) ⬆️
... and 47 more


| Output Column Name | Column Type | Description|
| -- | -- | -- |
| `Score` | array of <xref:System.Single> | The scores of all classes. Higher value means higher probability to fall into the associated class. If the i-th element has the lagest value, the predicted label index would be i. Note that i is zero-based index. |

@shmoradims shmoradims Apr 19, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array [](start = 12, length = 5)

if it's a vbuffer, let's call it 'vector' instead. #Resolved


| Output Column Name | Column Type | Description|
| -- | -- | -- |
| `Score` | array of <xref:System.Single> | The scores of all classes. Higher value means higher probability to fall into the associated class. If the i-th element has the lagest value, the predicted label index would be i. Note that i is zero-based index. |

@shmoradims shmoradims Apr 19, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lagest [](start = 172, length = 6)

typo: largest

please use spell checker. we won't catch all the typos manually.
https://marketplace.visualstudio.com/items?itemName=EWoodruff.VisualStudioSpellChecker #Resolved

@shmoradims shmoradims left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -521,8 +521,8 @@ public static OnlineGradientDescentTrainer OnlineGradientDescent(this Regression
/// Predict a target using a linear binary classification model trained with the <see cref="Trainers.LbfgsLogisticRegressionBinaryTrainer"/> trainer.

@singlis singlis Apr 20, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[](start = 11, length = 2)

Create , which predicts a ... #Resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is binary classifier. I shouldn't touch it. Thanks!


In reply to: 277117848 [](ancestors = 277117848)

@singlis singlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wschin
wschin merged commit e57e572 into dotnet:master Apr 20, 2019
@wschin
wschin deleted the me-xml branch April 20, 2019 06:19
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Related to documentation of ML.NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants